Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update messageListener when new entryNode is chosen #182

Merged
merged 7 commits into from
Feb 7, 2023
Merged

Update messageListener when new entryNode is chosen #182

merged 7 commits into from
Feb 7, 2023

Conversation

ItsLuized
Copy link
Contributor

@ItsLuized ItsLuized commented Feb 3, 2023 •
edited

Fixes #176

  • 1 more log on reliability-score

nionis
nionis suggested changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@nionis nionis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • usually when a function starts with get for example getMessageListener you expect that it returns you something
  • getMessageListener functionality should be part of selectEntryNode

@ItsLuized ItsLuized self-assigned this Feb 7, 2023
@nionis nionis merged commit 6e0566d into main Feb 7, 2023
@nionis nionis deleted the fix/update-messageListener branch February 7, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nionis nionis nionis approved these changes

@diegoalzate diegoalzate Awaiting requested review from diegoalzate

Assignees

@ItsLuized ItsLuized

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update hoprd message listener when re selecting entry node
3 participants
@ItsLuized @nionis @diegoalzate