Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add casting to num in sum of total amount funded #174

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Add casting to num in sum of total amount funded #174

merged 1 commit into from
Feb 2, 2023

Conversation

ItsLuized
Copy link
Contributor

Closes #166

@ItsLuized ItsLuized added the bug Something isn't working label Feb 1, 2023
@ItsLuized ItsLuized added this to the February 2023 milestone Feb 1, 2023
@ItsLuized ItsLuized self-assigned this Feb 1, 2023
diegoalzate
diegoalzate approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@diegoalzate diegoalzate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

would create a new issue for wei number that the Number constructor can not handle

@ItsLuized ItsLuized merged commit de4420e into main Feb 2, 2023
@ItsLuized ItsLuized deleted the fix/total_amount_funded_sum branch February 2, 2023 16:40
@nionis nionis removed this from the February 2023 milestone Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nionis nionis nionis approved these changes

@diegoalzate diegoalzate diegoalzate approved these changes

Assignees

@ItsLuized ItsLuized

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

total_amount_funded isn't the correct sum of what was funded to the nodes
3 participants
@ItsLuized @nionis @diegoalzate