Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better constants management for FS and DP #144

Merged
merged 6 commits into from
Jan 24, 2023
Merged

Better constants management for FS and DP #144

merged 6 commits into from
Jan 24, 2023

Conversation

diegoalzate
Copy link
Contributor

@diegoalzate diegoalzate commented Jan 19, 2023 •
edited

Closes #140

Todo

  • move all env variables to constants file
  • move all constants to constants file
  • replace the use of NODE_ENV for more descriptive variables like SKIP_COMMITMENT_CHECK and FORCE_CHAIN_ID
  • Update sandbox scripts

@diegoalzate diegoalzate added the enhancement New feature or request label Jan 19, 2023
@diegoalzate diegoalzate self-assigned this Jan 19, 2023
@diegoalzate diegoalzate changed the title added constants file to FS and DP Better constants management for FS and DP Jan 19, 2023
nionis
nionis suggested changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@nionis nionis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • the parsing should be done in constants since its where we read them from ENV
  • some minor feedback

apps/discovery-platform/src/graph-api/index.ts Outdated Show resolved Hide resolved
apps/funding-service/src/constants.ts Outdated Show resolved Hide resolved
nionis
nionis suggested changes Jan 23, 2023
View reviewed changes
apps/discovery-platform/src/constants.ts Outdated Show resolved Hide resolved
apps/funding-service/src/constants.ts Outdated Show resolved Hide resolved
@diegoalzate diegoalzate merged commit c3643ee into main Jan 24, 2023
@diegoalzate diegoalzate deleted the improve-env-handling branch January 24, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nionis nionis nionis approved these changes

Assignees

@diegoalzate diegoalzate

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve ENV handling for DP and FS
2 participants
@diegoalzate @nionis