Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect ecosystem #115

Merged
merged 30 commits into from
Jan 18, 2023
Merged

Connect ecosystem #115

merged 30 commits into from
Jan 18, 2023

Conversation

nionis
Copy link
Contributor

@nionis nionis commented Jan 4, 2023 •
edited by diegoalzate

Related to #31
Closes #73 #124 #121

Connects all components of the ecosystem together.

TODO:

  • update SDK to use discovery platform
  • upstream changes due to the SDK changes
  • update sandbox to register nodes automatically
  • ensure E2E tests pass
  • update BW integration
  • test with BW

@nionis nionis self-assigned this Jan 4, 2023
@diegoalzate diegoalzate mentioned this pull request Jan 12, 2023
Closed
3 tasks
@diegoalzate
Copy link
Contributor

diegoalzate commented Jan 13, 2023 •
edited

fixes #121

@diegoalzate diegoalzate marked this pull request as ready for review January 13, 2023 10:13
@ItsLuized ItsLuized mentioned this pull request Jan 13, 2023
Merged
diegoalzate and others added 2 commits January 16, 2023 14:39
@diegoalzate
fix check for pending requests
a387e77
Add filter to exitNodes selection (#125)
04e3de1 
* filter entryNode from exitNode selection by eliminating entry with same peerId as entryNode from nodes that have exit nodes
nionis
nionis commented Jan 16, 2023
View reviewed changes
apps/discovery-platform/dump.sql Outdated
hoprd_api_endpoint character varying(255) NOT NULL,
hoprd_api_port integer NOT NULL,
exit_node_pub_key character varying(255),
node_address character varying(255) NOT NULL,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this not the PeerId?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the address we are going to use to fund, so it is the blockchain address where the node runner will receive the funds not the peer id

apps/discovery-platform/src/entry-server/index.ts Outdated Show resolved Hide resolved
apps/discovery-platform/src/registered-node/index.spec.ts Outdated Show resolved Hide resolved
apps/discovery-platform/src/registered-node/index.ts Outdated Show resolved Hide resolved
apps/discovery-platform/src/entry-server/index.ts Outdated Show resolved Hide resolved
apps/funding-service/hardhat.config.ts Outdated Show resolved Hide resolved
apps/funding-service/src/blockchain/index.ts Outdated Show resolved Hide resolved
devkit/sandbox/src/fund-funding-service.ts Show resolved Hide resolved
nionis
nionis commented Jan 18, 2023
View reviewed changes
Copy link
Contributor Author

@nionis nionis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nionis nionis merged commit 2d4f52f into main Jan 18, 2023
@nionis nionis deleted the connect-ecosystem branch January 18, 2023 16:41
This was referenced Jan 18, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegoalzate diegoalzate diegoalzate left review comments

@ItsLuized ItsLuized ItsLuized left review comments

Assignees

@nionis nionis

@diegoalzate diegoalzate

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implement testing environment part 2
3 participants
@nionis @diegoalzate @ItsLuized