Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitlab initial implementation #190

Merged
merged 15 commits into from
Nov 16, 2017
Merged

Gitlab initial implementation #190

merged 15 commits into from
Nov 16, 2017

Conversation

lkysow
Copy link
Collaborator

@lkysow lkysow commented Nov 12, 2017

Gitlab Testing Todo

  • test pagination for Gitlab modified files api call
  • test against Gitlab enterprise
  • test merge request approvals (need enterprise)

Files to test

  • cmd/server
  • server/events/command_handler
  • server/events/event_parser
  • server/events/vcs/gitlab_client
  • server/events/vcs/proxy
  • server/events/vcs/not_configured_client
  • server/gitlab_request_parser
  • server/events_controller

Misc

  • add comments to all public methods/fields
  • rename GHStatusUpdater to Github..

@codecov-io
Copy link

codecov-io commented Nov 16, 2017

Codecov Report

Merging #190 into master will increase coverage by 2.57%.
The diff coverage is 65.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #190      +/-   ##
==========================================
+ Coverage   60.97%   63.54%   +2.57%     
==========================================
  Files          30       35       +5     
  Lines        1663     1986     +323     
==========================================
+ Hits         1014     1262     +248     
- Misses        613      683      +70     
- Partials       36       41       +5
Impacted Files Coverage Δ
cmd/root.go 0% <ø> (ø) ⬆️
server/events/vcs/gitlab_client.go 0% <0%> (ø)
server/events/vcs/proxy.go 0% <0%> (ø)
server/events/apply_executor.go 0% <0%> (ø) ⬆️
server/events/vcs/github_client.go 0% <0%> (ø)
server/events/vcs/not_configured_vcs_client.go 0% <0%> (ø)
server/logging/simple_logger.go 0% <0%> (ø) ⬆️
server/events/vcs/vcs.go 0% <0%> (ø)
server/events/plan_executor.go 88.05% <100%> (ø) ⬆️
server/events_controller.go 100% <100%> (ø) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec3d543...d1cf9aa. Read the comment docs.

@lkysow lkysow changed the title WIP: Gitlab Gitlab initial implementation Nov 16, 2017
@lkysow lkysow merged commit fa43feb into master Nov 16, 2017
@lkysow lkysow deleted the vcs branch November 16, 2017 21:22
@lkysow lkysow mentioned this pull request Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants