Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lambda-edge): add getConnInfo helper for Lambda@Edge #3099

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

yasuaki640
Copy link
Contributor

@yasuaki640 yasuaki640 commented Jul 6, 2024

Added getConnInfo for AWS Lambda@Edge.

Here is the code tested in the actual AWS environment.

https://github.com/yasuaki640/hono-lambda-edge-conninfo-20240705/blob/main/lambda/index_edge.ts

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

Copy link

codecov bot commented Jul 6, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.86%. Comparing base (72ee808) to head (6760e54).
Report is 8 commits behind head on main.

Files Patch % Lines
src/adapter/lambda-edge/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3099   +/-   ##
=======================================
  Coverage   95.86%   95.86%           
=======================================
  Files         137      138    +1     
  Lines       13481    13527   +46     
  Branches     2308     2263   -45     
=======================================
+ Hits        12923    12968   +45     
- Misses        558      559    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yusukebe yusukebe added the v4.5 label Jul 6, 2024
Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to add the following line in src/adapter/lambda-edge/index.ts:

export { getConnInfo } from './conninfo'

@yusukebe yusukebe changed the base branch from main to next July 6, 2024 08:19
@yusukebe yusukebe changed the base branch from next to main July 6, 2024 08:20
@yasuaki640
Copy link
Contributor Author

We have to add the following line in src/adapter/lambda-edge/index.ts:

export { getConnInfo } from './conninfo'

Added!

@yusukebe yusukebe changed the base branch from main to next July 8, 2024 14:31
@yasuaki640 yasuaki640 force-pushed the feat/add-lambda-edge-conninfo branch from 6760e54 to 4c401da Compare July 9, 2024 03:07
Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

@yasuaki640

Wonderful! I'll merge this into the next now. We can release 4.5.0 before long. Thanks!

@yusukebe yusukebe merged commit 4a4e851 into honojs:next Jul 11, 2024
26 checks passed
@yasuaki640 yasuaki640 deleted the feat/add-lambda-edge-conninfo branch July 11, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants