showImages video: Add volume control #4800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsjohnsen
force-pushed
the
showimages-video-volume-control
branch
3 times, most recently
from
f595ec1
to
ebfebbe
Compare
erikdesjardins
approved these changes
Aug 1, 2018
larsjohnsen
force-pushed
the
showimages-video-volume-control
branch
from
ebfebbe
to
392012a
Compare
larsjohnsen
force-pushed
the
showimages-video-volume-control
branch
from
392012a
to
4fa4968
Compare
|
Firefox integration test failure is due to infra (probably a bug in the current FF dev version), see #4827 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the nightly / betas of Firefox and Chrome no longer provides a granular volume control in their video controls, we might as well integrate it.
Basic volume controller:
Relevant issue: Closes #799,
Tested in browser: Chrome 68, Firefox 62