Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

showImages conserveMemory: Don't unload when scrolling horizontally #4767

Merged
merged 1 commit into from
May 16, 2018
Merged

showImages conserveMemory: Don't unload when scrolling horizontally #4767

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/modules/showImages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,7 +592,8 @@ function enableConserveMemory() {
// $FlowIssue `mozFullScreenElement` is not recognized
const fullscreenActive = () => !!(document.fullscreenElement || document.webkitFullscreenElement || document.mozFullScreenElement: any);

const rootMargin = `${100 * (parseInt(module.options.bufferScreens.value, 10) || 2)}%`;
// x-axis is set to 100000% in order to not unload images when scrolling too far horizontally
const rootMargin = `${100 * (parseInt(module.options.bufferScreens.value, 10) || 2)}% 100000%`;

const mediaMap = new WeakMap();
const ioMedia = new IntersectionObserver(entries => {
Expand Down