Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profileRedirect: use location.replace to avoid continuous redirect #4744

Merged
merged 1 commit into from
Apr 17, 2018

Conversation

mudkip908
Copy link
Contributor

Currently pressing the "Back" button after being redirected by profileRedirect will result in going back to the same page. Using location.replace prevents this behavior.

Currently pressing the "Back" button after being redirected by profileRedirect will result in going back to the same page. Using location.replace prevents this behavior.
@erikdesjardins
Copy link
Collaborator

Thanks!

@erikdesjardins erikdesjardins merged commit 0a82249 into honestbleeps:master Apr 17, 2018
@mudkip908 mudkip908 deleted the patch-1 branch April 17, 2018 14:53
larsjohnsen pushed a commit to larsjohnsen/Reddit-Enhancement-Suite that referenced this pull request Apr 18, 2018
…onestbleeps#4744)

Currently pressing the "Back" button after being redirected by profileRedirect will result in going back to the same page. Using location.replace prevents this behavior.
erikdesjardins added a commit that referenced this pull request May 2, 2018
…irect (#4744)"

This reverts commit 0a82249.

location.replace is only a visual change, so this doesn't work.
erikdesjardins added a commit that referenced this pull request May 2, 2018
…uous redirect (#4744)""

This reverts commit 0e7add8.

Actually, it does work
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants