nightmode: Don't change global state on load #4712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsjohnsen
force-pushed
the
nigthmode-local-state
branch
from
17c2796
to
acb8fef
Compare
The multicasted functions were invoked on all tabs, also those where nightmode was not running (d2x pages).
larsjohnsen
force-pushed
the
nigthmode-local-state
branch
from
acb8fef
to
9934800
Compare
erikdesjardins
approved these changes
Mar 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The multicasted functions were invoked on all tabs, also those where the nightmode module was not running (d2x pages).
Relevant issue:
Tested in browser: Chrome 65