Update go-mode hotkey filter #4704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To match the other filters, will only show hotkeys that are enabled options, specific to the page, etc.
Changed the names of all the 'Go to' hotkeys to start with "goto[Inbox|Frontpage|etc]" so it was more obvious which ones were linked with the Go-Mode function, based on it's description. Also made the popup show the friendly name.
lib/modules/keyboardNav.js
Outdated
| @@ -663,39 +663,39 @@ module.options = { | |||
| dependsOn: options => options.useGoMode.value, | |||
| callback() { if (module.options.useGoMode.value) toggleGoMode(); }, | |||
| }, | |||
| inbox: { | |||
| gotoInbox: { | |||
There was a problem hiding this comment.
If you change option keys, you also need to add a migration to move the value from the old key to the new key.
There was a problem hiding this comment.
Okay, I'll revert that part.
There was a problem hiding this comment.
Any other ideas on how to best denote which options are go-mode enabled? Should I just group them better, all at the bottom of the list?
jewel-andraia
previously requested changes
Mar 9, 2018
Grouped all the goto options together to make it more obvious which ones were affected.
|
Okay, I instead grouped all the options together and at the bottom.
|
larsjohnsen
reviewed
Mar 9, 2018
lib/modules/keyboardNav.js
Outdated
| const goModes = filterMap(Object.entries(module.options), ([key, opt]) => { | ||
| if (!opt.goMode) return; | ||
| return [{ key, niceKeyCode: niceKeyCode(opt.value) }]; | ||
| const goModes = filterMap(Object.entries(module.options), ([, option]) => { |
There was a problem hiding this comment.
Since filtering for valid shortcuts is already performed in getActiveCommandOptions, this may be simplified to
getActiveCommandOptions()
.filter(opt => opt.goMode)
.map(opt => ({ key: i18n(opt.title), niceKeyCode: niceKeyCode(opt.value) }))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To match the other filters, will only show hotkeys that are enabled options, specific to the page, etc. Previously was showing every option on every page, despite the options having
includeset for specific pages.Changed the names of all the 'Go to' hotkeys to start with "goto[Inbox|Frontpage|etc]" so it was more obvious which ones were linked with the Go-Mode function, based on it's description.Reordered the options so that all the 'Go to' hotkeys and options were grouped together at the bottom.
Also made the popup show the friendly name.