Added option to use legacy Reddit favicon #4699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/modules/orangered.js
Outdated
| @@ -216,6 +223,10 @@ const setupFaviconBadge = _.once(() => { | |||
| for (const f of favicons) { | |||
| if (f !== selectedFavicon) f.remove(); | |||
| } | |||
| // browser should auto resolve to this if all get removed, but just in case, setting it explicitly | |||
| if (module.options.faviconUseLegacy.value) { | |||
| selectedFavicon.href = '//www.reddit.com/favicon.ico'; | |||
There was a problem hiding this comment.
Let's use redditstatic.com instead of reddit.com
locales/locales/en.json
Outdated
| "message": "Use Legacy Favicon" | ||
| }, | ||
| "orangeredFaviconUseLegacyDesc": { | ||
| "message": "If you don't like the new orange Reddit favicon, revert to using the old Reddit icon instead." |
There was a problem hiding this comment.
Is it all fine now?
jewel-andraia
approved these changes
Mar 9, 2018
|
Build failure looks spurious |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could have made it not dependant on
showUnreadCountInFavicon, but it would have made it uglier and I don't think it matters much.