Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylesheets: display available customToggles #4657

Merged

Conversation

larsjohnsen
Copy link
Collaborator

@larsjohnsen larsjohnsen commented Jan 24, 2018

There has been some confusion about what the toggleName column does, and entering the wrong text there prevents the snippet from working.

This changes the option from text to enum. The value remains the same.

image

Tested in browser: Chrome 65

@jewel-andraia
Copy link
Collaborator

There might even be a GitHub ticket I opened which this could close.. I know I opened a different ticket for "automatically backfill custom toggles for toggleName values in snippets and other options."

@erikdesjardins erikdesjardins added this to the v5.11.x (v5.12.0) milestone Jan 25, 2018
@larsjohnsen larsjohnsen changed the title snippets: display available customToggles stylesheets: display available customToggles Apr 10, 2018
@larsjohnsen larsjohnsen merged commit ebffb27 into honestbleeps:master Apr 10, 2018
@larsjohnsen larsjohnsen deleted the snippets-customtoggles-enum branch August 28, 2018 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants