-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verification Request: homebridge-alphaess #720
Comments
🔴 The following pre-checks failed:
🟢 The following pre-checks passed:
|
/check |
🔴 The following pre-checks failed:
🟢 The following pre-checks passed:
|
maybe there is something not quite right with the github repo checks... will check later |
@bwp91 thanks for feedback, im a bit confused since most of the things area resolved. hmm. |
/check |
🔴 The following pre-checks failed:
🟢 The following pre-checks passed:
|
The github issues are failing because your package json file contains a different repo URL: "repository": {
"type": "git",
"url": "https://github.com/2rw0lff/homebridge-alphaess.git"
},
"bugs": {
"url": "https://github.com/2rw0lff/homebridge-alphaess/issues"
}, whereas in your ticket you specified https://github.com/zerwuff/homebridge-alphaess |
@bwp91 thanks |
/check |
🔴 The following pre-checks failed:
🟢 The following pre-checks passed:
|
/check |
/check |
🔴 The following pre-checks failed:
🟢 The following pre-checks passed:
|
hi @bwp91 still no success on it zerwuff/homebridge-alphaess@f18e8a6 what did i miss ? |
/check |
🔴 The following pre-checks failed:
🟢 The following pre-checks passed:
If updating your |
the latest npm release of your plugin does not include the change https://www.npmjs.com/package/homebridge-alphaess?activeTab=code |
/check |
🔴 The following pre-checks failed:
🟢 The following pre-checks passed:
If updating your |
hmm @bwp91 just created a new npm release and github release including the last commit. still failing, any ideas ? |
/check |
🟢 The following pre-checks passed:
🎉 All pre-checks passed successfully, nice work! Your plugin and/or icon will now be manually reviewed by the Homebridge team. |
|
Congratulations! Your plugin has been verified! You can now add one of the Verified by Homebridge badges to your plugin's README:
Your plugin is now also eligible to display a ❤️ Donate button on its tile in the Homebridge UI. See https://github.com/homebridge/homebridge/wiki/Donation-Links for instructions. If for any reason in the future you can no longer maintain your plugin, please consider transferring it to our unmaintained plugins repo. We can take ownership until another willing developer comes along. Don't forget to join the official Homebridge Discord server, where plugin developers can get tips and advice from other developers and the Homebridge project team in the #plugin-development channel! As a verified plugin, you can request a channel in the Discord server to discuss your plugin with users and other developers. Just ask in the #plugin-development channel. Thank you for your contribution to the Homebridge community.
|
Hi @zerwuff all good! I was just looking at your package dependencies and wondered if there was any that could be moved to In particular I was thinking about No problem of course if no changes are needed! |
hi @bwp91 thanks for the review & feedback. i did a garbage collection on package.json and did remove the jest-mock-server and some other unused stuff. thanks for looking into it! |
thanks for support |
Plugin Name
homebridge-alphaess
Link To GitHub Repo
https://github.com/zerwuff/homebridge-alphaess
Plugin Icon (Optional)
No response
The plugin does not offer the same nor less functionality than that of any existing verified plugin.
🟢 Yes
The plugin successfully installs and does not start unless it is configured.
🟢 Yes
The plugin does not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.
🟢 Yes
The plugin does not contain any analytics or calls that enable you to track the user.
🟢 Yes
If the plugin needs to write files to disk (cache, keys, etc.), it stores them inside the Homebridge storage directory.
🟢 Yes
The plugin does not throw unhandled exceptions, the plugin must catch and log its own errors.
🟢 Yes
More Information
Homebridge Plugin for Integration Alpha ESS Energy Storage Systems into the Home App.
This is done by integrating the alpha ess open api (REST) into the homebridge platform
The text was updated successfully, but these errors were encountered: