Move test classes to test main folder; #2807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgoncal
requested changes
Jun 4, 2024
| @@ -150,7 +151,8 @@ extension SettingsSceneDelegate: NSToolbarDelegate { | |||
| } | |||
| } | |||
|
|
|||
| @objc private func selectItem(_ item: NSToolbarItem) { | |||
| import Shared | ||
| import UIKit | ||
|
|
||
| extension UIImage { |
There was a problem hiding this comment.
Can you make a folder for extensions? I saw we have a few inside Utilities
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
mat1th
force-pushed
the
feature/move-test-files-to-test-folder
branch
from
db1b806
to
41234da
Compare
bgoncal
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pr does move test files to the test folder of the project.
Screenshots
NA
Link to pull request in Documentation repository
Any other notes