Keep only necessary webviews alive in the app #2749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still have to test on macOS, for iOS it is working great now, no webview lost in the way |
bgoncal
force-pushed
the
dealloc-webviews
branch
from
45c68d9
to
23122f4
Compare
Test done, in mac the scenario was even worse, everytime a window was opened then closed, that webview lived in memory until the app is killed |
zacwest
reviewed
Apr 30, 2024
| @@ -75,7 +75,7 @@ class WebViewWindowController { | |||
| // not changing anything, but handle the promises | |||
| updateRootViewController(to: rootController) | |||
| } else { | |||
| if let webViewController = WebViewController(restoring: .init(restorationActivity)) { | |||
| if let webViewController = makeWebViewIfNotInCache(restorationType: .init(restorationActivity)) { | |||
There was a problem hiding this comment.
How could this code path hit a case where it's cached already?
There was a problem hiding this comment.
The idea of the makeWebViewIfNotInCache is to make sure all webviews will be tracked in the cached dictionary, so in this case if it is not cached already it will then make a new webview and cache, otherwise we don't have how to control webviews that are created and left behind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I noticed we are losing web views during the usage of the App, for example, when the user logs out we create a new web view after it logs in, but the old webview was kept in memory due to strong reference of WKScriptMessageHandler or due to not be listed in our cached webviews dictionary (and then not removed).
This PR gains controls of creation and usage of webviews aswell as removing them when not needed anymore, it also fixes the issue that some users experience "failure to authenticate" notifications (that were partially caused by these ghost webviews)
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes