Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependecy and cleanup code #2581

Merged
merged 4 commits into from
Feb 23, 2024
Merged

Update dependecy and cleanup code #2581

merged 4 commits into from
Feb 23, 2024

Conversation

mat1th
Copy link
Contributor

@mat1th mat1th commented Feb 16, 2024

Summary

This pr intruduces the following changes:

Screenshots

No user faceing changes

Link to pull request in Documentation repository

NA

Any other notes

NA

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mat1th

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft February 16, 2024 13:17
@mat1th mat1th marked this pull request as ready for review February 16, 2024 13:40
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (6c34210) 27.54% compared to head (8f89e0c) 28.80%.
Report is 13 commits behind head on master.

Files Patch % Lines
...ponses/MobileAppConfig/MobileAppConfigAction.swift 0.00% 10 Missing ⚠️
...PI/Responses/MobileAppConfig/MobileAppConfig.swift 0.00% 6 Missing ⚠️
...hared/Environment/OnboardingStateObservation.swift 0.00% 5 Missing ⚠️
...esponses/MobileAppConfig/MobileAppConfigPush.swift 0.00% 4 Missing ⚠️
...tings/Connection/ConnectionURLViewController.swift 0.00% 2 Missing ⚠️
Sources/Shared/API/MJPEGStreamer.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2581      +/-   ##
==========================================
+ Coverage   27.54%   28.80%   +1.26%     
==========================================
  Files         311      323      +12     
  Lines       31699    23360    -8339     
==========================================
- Hits         8733     6730    -2003     
+ Misses      22966    16630    -6336     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bgoncal
Copy link
Member

bgoncal commented Feb 16, 2024

I'll test these changes next week, thank you for contributing!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to call super.urlSession...? Could you check that?

This comment was marked as outdated.

@bgoncal bgoncal requested a review from zacwest February 20, 2024 13:24
Copy link
Member

@bgoncal bgoncal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just take a look at the conflicts and then we can merge it

@bgoncal bgoncal merged commit 113d4fe into home-assistant:master Feb 23, 2024
6 of 7 checks passed
@mat1th mat1th deleted the feature/update-deps-and-cleanup-code branch February 23, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants