Add code coverage reporting to tests (#1412)

Adds code coverage reports to pull requests. Enabling code coverage gathering appears to be about a 25% increase in build time, unfortunately, so just enabling it for the App/Shared targets and doing it in a separate scheme so it doesn't impact local build times.
home-assistant · Jan 24, 2021 · b80c874 · b80c874
1 parent 5def7ad
commit b80c874
Show file tree

Hide file tree

Showing 17 changed files with 156 additions and 6 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -67,6 +67,9 @@ jobs:
  - name: Run tests
  run: bundle exec fastlane ios test
 
+ - uses: codecov/codecov-action@v1
+ name: "Upload Code Coverage"
+
  - uses: actions/upload-artifact@v2
  name: "Upload Test Logs"
  if: ${{ always() }}

diff --git a/HomeAssistant.xcodeproj/project.pbxproj b/HomeAssistant.xcodeproj/project.pbxproj
@@ -1923,7 +1923,7 @@
  path = AppleWatch;
  sourceTree = "<group>";
  };
- 1141182824AFA0F000E6525C /* Request&Response */ = {
+ 1141182824AFA0F000E6525C /* Networking */ = {
  isa = PBXGroup;
  children = (
  1141182524AF9A0500E6525C /* WebhookManager.swift */,
@@ -1938,7 +1938,7 @@
  117675EE252D5CA80047B1D3 /* WebhookResponseUpdateComplications.swift */,
  11C4629524B19FC700031902 /* URLSessionTask+WebhookPersisted.swift */,
  );
- path = "Request&Response";
+ path = Networking;
  sourceTree = "<group>";
  };
  1155DD07250F4100003405C0 /* Share */ = {
@@ -2924,7 +2924,7 @@
  children = (
  11AF4D0F249C7DD8006C74C0 /* Sensors */,
  B6A258442232485300ADD202 /* Alamofire+EncryptedResponses.swift */,
- 1141182824AFA0F000E6525C /* Request&Response */,
+ 1141182824AFA0F000E6525C /* Networking */,
  );
  path = Webhook;
  sourceTree = "<group>";

diff --git a/HomeAssistant.xcodeproj/xcshareddata/xcschemes/App-Debug.xcscheme b/HomeAssistant.xcodeproj/xcshareddata/xcschemes/App-Debug.xcscheme
@@ -45,7 +45,24 @@
  buildConfiguration = "Debug"
  selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
  selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
- shouldUseLaunchSchemeArgsEnv = "YES">
+ shouldUseLaunchSchemeArgsEnv = "YES"
+ onlyGenerateCoverageForSpecifiedTargets = "YES">
+ <CodeCoverageTargets>
+ <BuildableReference
+ BuildableIdentifier = "primary"
+ BlueprintIdentifier = "D03D891620E0A85200D4F28D"
+ BuildableName = "Shared.framework"
+ BlueprintName = "Shared-iOS"
+ ReferencedContainer = "container:HomeAssistant.xcodeproj">
+ </BuildableReference>
+ <BuildableReference
+ BuildableIdentifier = "primary"
+ BlueprintIdentifier = "B657A8E51CA646EB00121384"
+ BuildableName = "Home Assistant.app"
+ BlueprintName = "App"
+ ReferencedContainer = "container:HomeAssistant.xcodeproj">
+ </BuildableReference>
+ </CodeCoverageTargets>
  <Testables>
  <TestableReference
  skipped = "NO">

diff --git a/HomeAssistant.xcodeproj/xcshareddata/xcschemes/Tests-Unit.xcscheme b/HomeAssistant.xcodeproj/xcshareddata/xcschemes/Tests-Unit.xcscheme
@@ -0,0 +1,117 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<Scheme
+ LastUpgradeVersion = "1220"
+ version = "1.3">
+ <BuildAction
+ parallelizeBuildables = "YES"
+ buildImplicitDependencies = "YES">
+ <BuildActionEntries>
+ <BuildActionEntry
+ buildForTesting = "YES"
+ buildForRunning = "YES"
+ buildForProfiling = "YES"
+ buildForArchiving = "YES"
+ buildForAnalyzing = "YES">
+ <BuildableReference
+ BuildableIdentifier = "primary"
+ BlueprintIdentifier = "B657A8E51CA646EB00121384"
+ BuildableName = "Home Assistant.app"
+ BlueprintName = "App"
+ ReferencedContainer = "container:HomeAssistant.xcodeproj">
+ </BuildableReference>
+ </BuildActionEntry>
+ </BuildActionEntries>
+ </BuildAction>
+ <TestAction
+ buildConfiguration = "Debug"
+ selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
+ selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
+ shouldUseLaunchSchemeArgsEnv = "YES"
+ codeCoverageEnabled = "YES"
+ onlyGenerateCoverageForSpecifiedTargets = "YES">
+ <CodeCoverageTargets>
+ <BuildableReference
+ BuildableIdentifier = "primary"
+ BlueprintIdentifier = "D03D891620E0A85200D4F28D"
+ BuildableName = "Shared.framework"
+ BlueprintName = "Shared-iOS"
+ ReferencedContainer = "container:HomeAssistant.xcodeproj">
+ </BuildableReference>
+ <BuildableReference
+ BuildableIdentifier = "primary"
+ BlueprintIdentifier = "B657A8E51CA646EB00121384"
+ BuildableName = "Home Assistant.app"
+ BlueprintName = "App"
+ ReferencedContainer = "container:HomeAssistant.xcodeproj">
+ </BuildableReference>
+ </CodeCoverageTargets>
+ <Testables>
+ <TestableReference
+ skipped = "NO">
+ <BuildableReference
+ BuildableIdentifier = "primary"
+ BlueprintIdentifier = "B657A8FB1CA646EB00121384"
+ BuildableName = "Tests-App.xctest"
+ BlueprintName = "Tests-App"
+ ReferencedContainer = "container:HomeAssistant.xcodeproj">
+ </BuildableReference>
+ </TestableReference>
+ <TestableReference
+ skipped = "NO">
+ <BuildableReference
+ BuildableIdentifier = "primary"
+ BlueprintIdentifier = "D03D894120E0BC1800D4F28D"
+ BuildableName = "Tests-Shared.xctest"
+ BlueprintName = "Tests-Shared"
+ ReferencedContainer = "container:HomeAssistant.xcodeproj">
+ </BuildableReference>
+ </TestableReference>
+ </Testables>
+ </TestAction>
+ <LaunchAction
+ buildConfiguration = "Debug"
+ selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
+ selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
+ launchStyle = "0"
+ useCustomWorkingDirectory = "NO"
+ ignoresPersistentStateOnLaunch = "NO"
+ debugDocumentVersioning = "YES"
+ migratedStopOnEveryIssue = "YES"
+ debugServiceExtension = "internal"
+ allowLocationSimulation = "YES">
+ <BuildableProductRunnable
+ runnableDebuggingMode = "0">
+ <BuildableReference
+ BuildableIdentifier = "primary"
+ BlueprintIdentifier = "B657A8E51CA646EB00121384"
+ BuildableName = "Home Assistant.app"
+ BlueprintName = "App"
+ ReferencedContainer = "container:HomeAssistant.xcodeproj">
+ </BuildableReference>
+ </BuildableProductRunnable>
+ </LaunchAction>
+ <ProfileAction
+ buildConfiguration = "Release"
+ shouldUseLaunchSchemeArgsEnv = "YES"
+ savedToolIdentifier = ""
+ useCustomWorkingDirectory = "NO"
+ debugDocumentVersioning = "YES">
+ <BuildableProductRunnable
+ runnableDebuggingMode = "0">
+ <BuildableReference
+ BuildableIdentifier = "primary"
+ BlueprintIdentifier = "B657A8E51CA646EB00121384"
+ BuildableName = "Home Assistant.app"
+ BlueprintName = "App"
+ ReferencedContainer = "container:HomeAssistant.xcodeproj">
+ </BuildableReference>
+ </BuildableProductRunnable>
+ </ProfileAction>
+ <AnalyzeAction
+ buildConfiguration = "Debug">
+ </AnalyzeAction>
+ <ArchiveAction
+ buildConfiguration = "Release"
+ revealArchiveInOrganizer = "YES">
+ </ArchiveAction>
+</Scheme>
diff --git a/...st&Response/Promise+RetryNetworking.swift → .../Networking/Promise+RetryNetworking.swift b/...st&Response/Promise+RetryNetworking.swift → .../Networking/Promise+RetryNetworking.swift
diff --git a/...equest&Response/Promise+WebhookJson.swift → ...hook/Networking/Promise+WebhookJson.swift b/...equest&Response/Promise+WebhookJson.swift → ...hook/Networking/Promise+WebhookJson.swift
diff --git a/...nse/URLSessionTask+WebhookPersisted.swift → ...ing/URLSessionTask+WebhookPersisted.swift b/...nse/URLSessionTask+WebhookPersisted.swift → ...ing/URLSessionTask+WebhookPersisted.swift
diff --git a/...ook/Request&Response/WebhookManager.swift → ...I/Webhook/Networking/WebhookManager.swift b/...ook/Request&Response/WebhookManager.swift → ...I/Webhook/Networking/WebhookManager.swift
diff --git a/...ook/Request&Response/WebhookRequest.swift → ...I/Webhook/Networking/WebhookRequest.swift b/...ook/Request&Response/WebhookRequest.swift → ...I/Webhook/Networking/WebhookRequest.swift
diff --git a/...est&Response/WebhookResponseHandler.swift → ...k/Networking/WebhookResponseHandler.swift b/...est&Response/WebhookResponseHandler.swift → ...k/Networking/WebhookResponseHandler.swift
diff --git a/...st&Response/WebhookResponseLocation.swift → .../Networking/WebhookResponseLocation.swift b/...st&Response/WebhookResponseLocation.swift → .../Networking/WebhookResponseLocation.swift
diff --git a/...Response/WebhookResponseServiceCall.swift → ...tworking/WebhookResponseServiceCall.swift b/...Response/WebhookResponseServiceCall.swift → ...tworking/WebhookResponseServiceCall.swift
diff --git a/...t&Response/WebhookResponseUnhandled.swift → ...Networking/WebhookResponseUnhandled.swift b/...t&Response/WebhookResponseUnhandled.swift → ...Networking/WebhookResponseUnhandled.swift
diff --git a/.../WebhookResponseUpdateComplications.swift → .../WebhookResponseUpdateComplications.swift b/.../WebhookResponseUpdateComplications.swift → .../WebhookResponseUpdateComplications.swift
diff --git a/...sponse/WebhookResponseUpdateSensors.swift → ...orking/WebhookResponseUpdateSensors.swift b/...sponse/WebhookResponseUpdateSensors.swift → ...orking/WebhookResponseUpdateSensors.swift
diff --git a/codecov.yaml b/codecov.yaml
@@ -0,0 +1,14 @@
+coverage:
+ status:
+ project:
+ shared:
+ paths:
+ - Sources/Shared
+ app:
+ paths:
+ - Sources/App
+ignore:
+- Sources/Shared/Resources
+- Sources/App/Resources
+- Tests
+- Pods
diff --git a/fastlane/Fastfile b/fastlane/Fastfile
@@ -272,8 +272,7 @@ platform :ios do
  lane :test do
  run_tests(
  workspace: 'HomeAssistant.xcworkspace', 
- scheme: 'App-Debug', 
- prelaunch_simulator: true,
+ scheme: 'Tests-Unit', 
  result_bundle: true
  )
  end