Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for Epson projector support in HA #5005

Merged
merged 10 commits into from
Jun 13, 2018
Merged

Documentation for Epson projector support in HA #5005

merged 10 commits into from
Jun 13, 2018

Conversation

pszafer
Copy link
Contributor

@pszafer pszafer commented Mar 24, 2018

Description:

Pull request in home-assistant (if applicable): home-assistant/core#14841

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

@frenck frenck added the new-integration This PR adds documentation for a new Home Assistant integration label Mar 24, 2018
host: 192.168.0.123
```

Configuration variables:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the configuration tags, for more information please see:
https://home-assistant.io/developers/documentation/create_page/#configuration

logo: epson.png
ha_category: Media Player
featured: true
ha_release: "0.66"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature won't make it into 0.66 since it has been frozen already.
Maybe update it to 0.67?

ha_release: "0.66"
ha_iot_class: "Local Push"
---

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One newline to many

@frenck
Copy link
Member

frenck commented Mar 24, 2018

Thank you @pszafer for this PR! I've reviewed it and left you some comments.
Could you please take a look? 👍

@pszafer
Copy link
Contributor Author

pszafer commented Mar 24, 2018

@frenck thanks for help!
In configuration section is it possible to define boolean value?
I see in docs that there are only such values string, int, time, template or map

@frenck frenck self-assigned this Mar 24, 2018
@dale3h
Copy link
Member

dale3h commented Mar 27, 2018

@pszafer Yes, you can define a bool or boolean value in the configuration section. You can use any value for the type key.

The reason this build is failing is because there is a : missing after port in the configuration section (on line 32).

- set/get color mode
- increase/decrease volume via HDMI CEC
- mute/unmute volume and video input
- send next/previous track via HDMI CEC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there are projectors with internal media players or speakers the command may apply to the projector itself. Thus I would remove "via HDMI CEC".

Supported devices:
- Epson EH-TW5350

To make this module work you need to connect your projector to WiFi. The best is to use iProjection app by Epson to test if it is working.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The component should also work via LAN. Thus, I suggest to replace WiFi by local network.

frenck
frenck previously approved these changes Apr 2, 2018
@frenck frenck unassigned frenck and pszafer Apr 2, 2018
@frenck
Copy link
Member

frenck commented Apr 2, 2018

Approved 🏅

Can be merged as soon as the parent PR gets merged.

frenck
frenck previously approved these changes Apr 6, 2018
@stale
Copy link

stale bot commented Jun 5, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale The PR had no activity for quite some time, and is marked as Stale label Jun 5, 2018
@stale stale bot removed the Stale The PR had no activity for quite some time, and is marked as Stale label Jun 6, 2018
footer: true
logo: epson.png
ha_category: Media Player
ha_release: 0.68
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.72

logo: epson.png
ha_category: Media Player
ha_release: 0.68
ha_iot_class: "Local Push"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local Polling

description: The HTTP port number. Defaults to 80.
required: false
type: int
name:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add a key for all the optional items named default that has the default value for the item as value.

port:
 ...
  default: 80

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@MartinHjelmare MartinHjelmare merged commit 5cbaf8f into home-assistant:next Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-integration This PR adds documentation for a new Home Assistant integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants