Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about mDNS with KVM bridged networking #16298

Merged
merged 2 commits into from
Jan 25, 2021

Conversation

chrwei
Copy link
Contributor

@chrwei chrwei commented Jan 24, 2021

Proposed change

Add additional instruction for KVM. trustGuestRxFilters is required to support multicast, and thus mDNS. Without it, some of the instructions and guides won't work as-is. Most notably, homeassistant.local won't resolve, and Google Cast devices won't be found.

Type of change

  • [X ] Adjusted missing or incorrect information in the current documentation (current branch).

Checklist

  • [X ] This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • [X ] The documentation follows the Home Assistant documentation [standards][].

trustGuestRxFilters is required to support multicast, and thus mDNS.  Without it, some of the instructions and guides won't work as-is.  Most notably, homeassistant.local won't resolve, and Google Cast devices won't be found.
@homeassistant
Copy link

Hi @chrwei,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant probot-home-assistant bot added the current This PR goes into the current branch label Jan 24, 2021
@frenck frenck added this to Ready for review in Content improvements via automation Jan 25, 2021
Content improvements automation moved this from Ready for review to Reviewer approved Jan 25, 2021
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @chrwei 👍

@frenck frenck merged commit e6af2f6 into home-assistant:current Jan 25, 2021
Content improvements automation moved this from Reviewer approved to Done Jan 25, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed current This PR goes into the current branch
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants