Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trigger.markdown #16257

Merged
merged 3 commits into from
Jan 25, 2021
Merged

Update trigger.markdown #16257

merged 3 commits into from
Jan 25, 2021

Conversation

kozerskil
Copy link
Contributor

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue:

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@homeassistant
Copy link

Hi @kozerskil,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant probot-home-assistant bot added the current This PR goes into the current branch label Jan 21, 2021
@frenck frenck added this to Ready for review in Content improvements via automation Jan 21, 2021
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Alright, thanks @kozerskil 👍

Content improvements automation moved this from Ready for review to Reviewer approved Jan 25, 2021
@frenck frenck merged commit 24d84ac into home-assistant:current Jan 25, 2021
Content improvements automation moved this from Reviewer approved to Done Jan 25, 2021
@kozerskil
Copy link
Contributor Author

Thank YOU @frenck for your hard work!
Now, when we agreed how it should work, maybe you can take a look at the behaviour I see from time to time. Probably it's not the best place to do it but I'm confused whether it's expected or not.
I have an automation (simplified version):

  trigger:
    - platform: numeric_state
      entity_id: sensor.mi_humidifier_h
      below: 55
      for: "00:15:00"
  action:
    - service: notify.lukbot
      data_template:
        target: "#humidifier"
        message: >
          humidifier automation, trigger {{ trigger }}

And from time to time I see something like this:

humidifier automation, trigger {'platform': 'numeric_state', 'entity_id': 'sensor.mi_humidifier_h', 'below': 55.0, 'above': None, 'from_state': <state sensor.mi_humidifier_h=39; unit_of_measurement=%, friendly_name=Wilgotność na nawilżaczu @ 2021-01-25T12:12:02.247523+01:00>, 'to_state': <state sensor.mi_humidifier_h=40; unit_of_measurement=%, friendly_name=Wilgotność na nawilżaczu @ 2021-01-25T12:16:04.945406+01:00>, 'for': datetime.timedelta(seconds=900), 'description': 'numeric state of sensor.mi_humidifier_h'}

The state changes from 39 to 40 and still the trigger below: 55 fires. Is it a bug or I'm missing something?

@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed current This PR goes into the current branch
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants