Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the sample of DB size sensor for MS SQL. #15529

Merged
merged 2 commits into from
Jan 25, 2021
Merged

Added the sample of DB size sensor for MS SQL. #15529

merged 2 commits into from
Jan 25, 2021

Conversation

slydiman
Copy link
Contributor

@slydiman slydiman commented Nov 3, 2020

Proposed change

Added the sample of DB size sensor for MS SQL.

Note this sample will work after fixing the issue home-assistant/core#42715
Currently MS SQL is not supported at all.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue:

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Nov 3, 2020
@klaasnicolaas klaasnicolaas added this to To Do in New documentation via automation Nov 3, 2020
@klaasnicolaas klaasnicolaas added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label Nov 3, 2020
New documentation automation moved this from To Do to Awaiting Parent PR Nov 6, 2020
frenck
frenck previously approved these changes Nov 6, 2020
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Nov 6, 2020
@slydiman
Copy link
Contributor Author

What awaits-parent means? What's next?

@frenck
Copy link
Member

frenck commented Jan 25, 2021

It is marked against the next branch and link to the core repository. Mean it is awaiting code? That is what the next branch is for @slydiman. Is that incorrect @slydiman ?

@slydiman
Copy link
Contributor Author

It is marked against the next branch and link to the core repository. Mean it is awaiting code? That is what the next branch is for @slydiman. Is that incorrect @slydiman ?

I have no idea what it is awaiting for.
home-assistant/core#42715 is closed.
home-assistant/core#42778 is merged.

@dgomes (author of SQL sensor) asked me to add this myself

I invite you to contribute directly :) it's easy just follow the link https://github.com/home-assistant/home-assistant.github.io/tree/current/source/_integrations/sql.markdown

But your approval mechanism is too complicated.
Please update it as needed to merge and close finally.
Thanks in advance.

@dgomes
Copy link
Contributor

dgomes commented Jan 25, 2021

Yep, this should have been accepted long time ago, it was next, now it's current

@frenck
Copy link
Member

frenck commented Jan 25, 2021

home-assistant/core#42778 <- Is now for the first time referenced in your last comment. Meaning it now becomes apparent for the first time the parent has been merged already.

I'll see where I can merge it into.

@frenck frenck changed the base branch from next to current January 25, 2021 15:34
@frenck frenck dismissed their stale review January 25, 2021 15:34

The base branch was changed.

@probot-home-assistant probot-home-assistant bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Jan 25, 2021
@probot-home-assistant probot-home-assistant bot added current This PR goes into the current branch and removed next This PR goes into the next branch labels Jan 25, 2021
@frenck frenck merged commit 154dbfa into home-assistant:current Jan 25, 2021
New documentation automation moved this from Awaiting Parent PR to Done Jan 25, 2021
@probot-home-assistant probot-home-assistant bot removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch in-progress This PR/Issue is currently being worked on awaits-parent Awaits the merge of an parent PR labels Jan 25, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck left review comments

Assignees

@frenck frenck

Labels
current This PR goes into the current branch has-parent This PR has a parent PR in a other repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration
Projects
No open projects
New documentation
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@slydiman @frenck @dgomes @klaasnicolaas