Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2021.11.0 #58994

Merged
merged 1,040 commits into from
Nov 3, 2021
Merged

2021.11.0 #58994

merged 1,040 commits into from
Nov 3, 2021

Conversation

frenck
Copy link
Member

@frenck frenck commented Nov 3, 2021

image

bdraco and others added 30 commits October 25, 2021 08:56
* Update PyVicare to 2.x

With PyViCare 2.8.1 a breaking change was introduced which required changes on sensor and binary_sensor platforms:
- Circuit, Burner and Compressor have been separated out from the "main" device
- Multiple circuits and burners allow "duplicate sensors". We add the circuit or burner number as suffix now

At the same time the sensors are now created only when available:
During entity creation we can check if the value is provided for the user's device.

Sensors are not created by heating type anymore but instead the new API structure is reflected, providing device, burner or circuit sensors.

For details of breaking changes from PyViCare 1.x to 2.x please see https://github.com/somm15/PyViCare#breaking-changes-in-version-2x

* Integrate review comments

* variables cleanup

* Update unique ids

The unique ids shall not depend on the name but on the entity
description key (which should not change) and the id of the circuit,
burner or device.
* Use DeviceInfo in mqtt

* Updates for mypy

Co-authored-by: epenet <[email protected]>
* Allow extra keys in MQTT discovery messages

* Remove extra keys
@frenck frenck requested review from zxdavb and a team as code owners November 3, 2021 14:05
@homeassistant
Copy link
Contributor

Hi @GitHub-Action,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant
Copy link

Hey there @bieniu, mind taking a look at this pull request as it has been labeled with an integration (accuweather) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link

Hey there @atmurray, mind taking a look at this pull request as it has been labeled with an integration (acmeda) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link

Hey there @Bre77, mind taking a look at this pull request as it has been labeled with an integration (advantage_air) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link

Hey there @Danielhiversen, mind taking a look at this pull request as it has been labeled with an integration (adax) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link

Hey there @shred86, mind taking a look at this pull request as it has been labeled with an integration (abode) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Nov 3, 2021
Dev automation moved this from By Code Owner to Reviewer approved Nov 3, 2021
@aprosvetova

This comment has been minimized.

@frenck frenck merged commit 85a4ee6 into master Nov 3, 2021
Dev automation moved this from Reviewer approved to Done Nov 3, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet