Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tplink device tracker #27936

Merged
merged 3 commits into from
Oct 20, 2019

Conversation

rytilahti
Copy link
Member

@rytilahti rytilahti commented Oct 19, 2019

Breaking Change:

Users of device_tracker.tplink need to find another way to do device tracking.

Description:

Version 0.94 added a distress signal (#24236) and since then nothing has happened.
This commit removes the device tracker which should have never been
a part of tplink integration in the first place as it does not share
anything with this pyhs100-based integration / kasa smarthome.

I'll mark this as WIP to see if someone comes up and wants to create a new integration based on the tplink library and maintain it. If nothing happens, I'm going to create soon a PR to remove the relevant documentation.

I'll highlight the related issues from the distress signal PR in case that will help finding someone interested on this: #24091 #14641 #20769 #24140 #13991 #11827 #10575 #17371 #14801 #13525 #10506

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10906

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Version 0.94 added a distress signal and since then nothing has happened.
This commit removes the device tracker which should have never been
a part of tplink integration in the first place as it does not share
anything with this pyhs100-based integration / kasa smarthome.
@project-bot project-bot bot added this to Needs review in Dev Oct 19, 2019
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Oct 19, 2019
Dev automation moved this from By Code Owner to Reviewer approved Oct 20, 2019
Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kill it.

@rytilahti rytilahti changed the title WIP: Remove tplink device tracker Remove tplink device tracker Oct 20, 2019
@rytilahti rytilahti merged commit ac5ce41 into home-assistant:dev Oct 20, 2019
Dev automation moved this from Reviewer approved to Done Oct 20, 2019
@rytilahti rytilahti deleted the drop_tplink_devicetracker branch October 20, 2019 16:11
@lock lock bot locked and limited conversation to collaborators Oct 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants