Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aioautomower to 2024.4.3 #114500

Merged
merged 29 commits into from
Apr 23, 2024
Merged

Conversation

Thomas55555
Copy link
Contributor

@Thomas55555 Thomas55555 commented Mar 30, 2024

Breaking change

Proposed change

Fix an error introduced in #114127: When data.planner.next_start_datetime was None an error occured.
Also the timezone was not always correct. It worked in the dev container, where the timezone was set to UTC, but not in the production environment where the timezone was different.
Fix: Thomas55555/aioautomower#235
Release note: https://github.com/Thomas55555/aioautomower/releases/tag/2024.3.5
Release note: https://github.com/Thomas55555/aioautomower/releases/tag/2024.4.0
Release note: https://github.com/Thomas55555/aioautomower/releases/tag/2024.4.1
Release note: https://github.com/Thomas55555/aioautomower/releases/tag/2024.4.2
Release note: https://github.com/Thomas55555/aioautomower/releases/tag/2024.4.3
diff: Thomas55555/aioautomower@2024.3.4...2024.4.3

This is a hotfix and should be included in the next patch release.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@Thomas55555 Thomas55555 marked this pull request as ready for review March 31, 2024 17:11
@Thomas55555 Thomas55555 marked this pull request as draft March 31, 2024 17:13
@Thomas55555 Thomas55555 marked this pull request as ready for review March 31, 2024 17:43
jpbede
jpbede previously requested changes Mar 31, 2024
homeassistant/components/husqvarna_automower/sensor.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft March 31, 2024 19:56
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Copy link
Contributor

@slovdahl slovdahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how these things work, but doesn't Thomas55555/aioautomower#235 overwrite the timezone globally in the Python process? 🤔

@jpbede
Copy link
Member

jpbede commented Apr 1, 2024

Yep it would, or at least cause other problems I guess

@gjohansson-ST gjohansson-ST linked an issue Apr 2, 2024 that may be closed by this pull request
@frenck frenck added this to the 2024.4.4 milestone Apr 12, 2024
@home-assistant home-assistant bot marked this pull request as draft April 19, 2024 16:35
@frenck frenck removed this from the 2024.4.4 milestone Apr 19, 2024
@Thomas55555 Thomas55555 changed the title Bump aioautomower to 2024.4.0 Bump aioautomower to 2024.4.2 Apr 20, 2024
@Thomas55555
Copy link
Contributor Author

Test failure not related to this PR

@Thomas55555 Thomas55555 marked this pull request as ready for review April 20, 2024 19:45
@home-assistant home-assistant bot requested a review from frenck April 20, 2024 19:45
@Thomas55555 Thomas55555 changed the title Bump aioautomower to 2024.4.2 Bump aioautomower to 2024.4.3 Apr 22, 2024
@cyr-ius
Copy link
Contributor

cyr-ius commented Apr 22, 2024

This PR fix issue #115988

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Thomas55555 👍

../Frenck

@frenck frenck dismissed jpbede’s stale review April 23, 2024 20:23

Comment addressed

@frenck frenck merged commit f1fa334 into home-assistant:dev Apr 23, 2024
38 checks passed
@Thomas55555 Thomas55555 deleted the Fix-timezone branch April 23, 2024 21:52
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.