-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump aioautomower to 2024.4.3 #114500
Bump aioautomower to 2024.4.3 #114500
Conversation
f30059a
to
f70ac23
Compare
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how these things work, but doesn't Thomas55555/aioautomower#235 overwrite the timezone globally in the Python process? 🤔
Yep it would, or at least cause other problems I guess |
Test failure not related to this PR |
This PR fix issue #115988 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Thomas55555 👍
../Frenck
Breaking change
Proposed change
Fix an error introduced in #114127: When
data.planner.next_start_datetime
wasNone
an error occured.Also the timezone was not always correct. It worked in the dev container, where the timezone was set to UTC, but not in the production environment where the timezone was different.Fix: Thomas55555/aioautomower#235Release note: https://github.com/Thomas55555/aioautomower/releases/tag/2024.3.5
Release note: https://github.com/Thomas55555/aioautomower/releases/tag/2024.4.0
Release note: https://github.com/Thomas55555/aioautomower/releases/tag/2024.4.1
Release note: https://github.com/Thomas55555/aioautomower/releases/tag/2024.4.2
Release note: https://github.com/Thomas55555/aioautomower/releases/tag/2024.4.3
diff: Thomas55555/aioautomower@2024.3.4...2024.4.3
This is a hotfix and should be included in the next patch release.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: