Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BAF without Auto Comfort support show tempratures in the UI #72934

Closed
jdoss opened this issue Jun 2, 2022 · 7 comments · Fixed by #72948
Closed

BAF without Auto Comfort support show tempratures in the UI #72934

jdoss opened this issue Jun 2, 2022 · 7 comments · Fixed by #72948
Assignees

Comments

@jdoss
Copy link

jdoss commented Jun 2, 2022

The problem

This new integration to add support for the new firmware on Big Ass Fans #71498 was just added by @bdraco. It works great, but for fans that do not have the Auto Comfort features they report an incorrect temperature in the UI.

image

My BAF is an older Haiku L series.

What version of Home Assistant Core has the issue?

core-2022.6

What was the last working version of Home Assistant Core?

N/A

What type of installation are you running?

Home Assistant Container

Integration causing the issue

Big Ass Fans

Link to integration documentation on our website

https://www.home-assistant.io/integrations/baf/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

@probot-home-assistant
Copy link

baf documentation
baf source
(message by IssueLinks)

@probot-home-assistant
Copy link

Hey there @bdraco, @jfroy, mind taking a look at this issue as it has been labeled with an integration (baf) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@bdraco
Copy link
Member

bdraco commented Jun 2, 2022

I think we are going to have to add diagnostics support so we can figure out which property we can use to exclude this

@jfroy
Copy link
Contributor

jfroy commented Jun 2, 2022

@jdoss If you're comfortable running some python, could you run the following? It should help us fix this before we have full diagnostics support.

python3 -m venv hass72934
source ./hass72934/bin/activate
pip3 install aiobafi6
aiobafi6 --discover
# ^C when you have your fan's IP
aiobafi6 --direct --dump --ip <IP>
# ^C when the program reaches steady state, a second or so

In the current directory, you'll find a bunch of dump-query-x.bin files. Compress and attach them.

@jdoss
Copy link
Author

jdoss commented Jun 2, 2022

@jfroy sure thing. See attached.

hass72934_files.tar.gz

jfroy added a commit to jfroy/aiobafi6 that referenced this issue Jun 3, 2022
This commit defines 2 unknown fields in the `Capabilities` message that
are not set on fans without auto comfort. The `Device` property exposes a
new computed property (`has_auto_comfort`) when both of those fields are
set to true.

See home-assistant/core#72934
@jfroy
Copy link
Contributor

jfroy commented Jun 3, 2022

@bdraco Published aiobafi6 0.5.0 with a new property that indicates support for auto comfort. https://github.com/jfroy/aiobafi6/releases/tag/0.5.0

@bdraco
Copy link
Member

bdraco commented Jun 3, 2022

Thanks @jfroy 🚀

bdraco added a commit to bdraco/home-assistant that referenced this issue Jun 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants