Add NFC state sensor #3905
Merged
Add NFC state sensor #3905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpelgrom
reviewed
Oct 2, 2023
common/src/main/java/io/homeassistant/companion/android/common/sensors/NfcSensorManager.kt
Outdated
Show resolved
Hide resolved
common/src/main/java/io/homeassistant/companion/android/common/sensors/NfcSensorManager.kt
Outdated
Show resolved
Hide resolved
jpelgrom
approved these changes
Oct 3, 2023
…_CHANGED in both the app and wear modules
|
Rebased onto |
|
Whoops, the GitHub Actions job failed with a |
|
Restarted and everything completed ✅. You shouldn't need to rebase unless there is a merge conflict or weeks have passed. |
JBassett
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a new
binary_sensorwhich represents whether the device has its NFC sensor enabled or not.I added the new
NfcSensorManagerclass to thecommonmodule, so it also works on Wear OS! I tested it on Wear OS 3.5.The sensor reacts to changes immediately by subscribing to
NfcAdapter.ACTION_ADAPTER_STATE_CHANGED.Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#992
Any other notes