Skip to content
This repository has been archived by the owner on Oct 1, 2021. It is now read-only.

Allow detecting deCONZ separately from Philips Hue bridges #156

Merged
merged 3 commits into from
Nov 23, 2017
Merged

Allow detecting deCONZ separately from Philips Hue bridges #156

merged 3 commits into from
Nov 23, 2017

Conversation

kroimon
Copy link
Contributor

@kroimon kroimon commented Nov 19, 2017

This will allow auto-discovery for the new deconz component that is currently being developed at home-assistant/core#10321.

This also requires changing the Hue detection as deCONZ tries to emulate a Hue bridge.
This gist shows the differences in SSDP replies of deCONZ and a real Hue bridge: https://gist.github.com/kroimon/97c82ace08fa9787cd9e52acfba8486b

This requires changing the Hue detection as deCONZ tries to emulate a Hue bridge.
@homeassistant
Copy link

Hello @kroimon,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

  1. If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.

  2. If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.

    • If you only made a single commit you should be able to run
      git commit --amend --author="Author Name <[email protected]>"
      
      (substituting Author Name and [email protected] for your actual information) to set the authorship information.
    • If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
      1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
      2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
    • Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! ❤️

@homeassistant
Copy link

Hi @kroimon,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@Kane610
Copy link
Contributor

Kane610 commented Nov 19, 2017

Looks good to me! Maybe you just need to double check that there are no other services out there imitating hue gateways. It might affect other users. The other way to do it would be to limit in the hue component not to do anything with Dresden electronics devices

@balloob
Copy link
Collaborator

balloob commented Nov 23, 2017

I think that this is the right way to go .

@balloob balloob merged commit 9f80753 into home-assistant-libs:master Nov 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants