Replace Buffer with b4a
#98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Ah, good catch! |
|
@kasperisager can we split this into two PRs? One for turbo and one for b4a? |
|
That would cause them to conflict, but I can absolutely split them if you'd prefer to land one or the other first? |
|
Ya b4a first, because I'm unsure if we'll land turbo anytime soon. Benchmarks showed some weird behaivour that we have to investigate, so don't want that to hold up b4a |
Buffer with b4a and turbo-hash-mapBuffer with b4a
|
@mafintosh All set! |
|
The tests are stalling on Windows for some reason 🤔 |
|
Stall is another test regression, we've discovered. Debugging that separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.