-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ingredients in Italian #39
Conversation
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 5 +2
Lines 17 32 +15
Branches 4 5 +1
=========================================
+ Hits 17 32 +15
Continue to review full report at Codecov.
|
@hmontazeri Can you please have a look at this pull request ? |
sure @gianantoniopini as soon as I find a free minute. Thanks for the PR. |
@hmontazeri Hi Hamed, thanks. |
@gianantoniopini do we really need the dependency to validate.js? |
@hmontazeri Regarding the dependency to validate.js. Currently it is used in the new setIngredientsLanguage function to perform basic validation when setting a new ingredients language. I thought it might be a good idea to sort of "delegate" the validation to this package. But we could also remove this dependency and implement the validation code ourselves, if you think it might be better. |
I’d rather have no dependency to other packages if not really necessary... so I’d recommend we do it ourself as it’s just a basic validation if language is set or not. Do you agree? |
Yes, i understand. I will move the validation implementation to our package and remove the dependency to validate.js . It should be a simple change. |
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 5 +2
Lines 17 31 +14
Branches 4 7 +3
=========================================
+ Hits 17 31 +14
Continue to review full report at Codecov.
|
@hmontazeri Just committed the change to remove the dependency to validate.js |
Checking it! Getting back to you soon. Thanks |
Looks good to time @gianantoniopini. Thanks for the effort 👍 |
Added first version of ingredients .json files in Italian ('it') and new function to set the ingredients language.
In order to add support for more languages in the future, the ingredients .json files will need to be added under the i18n directory, as already done for 'it'.
Resolves #14