Feature/faster parsing #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter279k
reviewed
Nov 27, 2020
src/HJSON/HJSONParser.php
Outdated
| @@ -5,7 +5,8 @@ | |||
| class HJSONParser | |||
| { | |||
|
|
|||
| private $text; | |||
| private $text_array; | |||
There was a problem hiding this comment.
Wrong coding style. It should be $textArray.
peter279k
reviewed
Nov 27, 2020
src/HJSON/HJSONParser.php
Outdated
|
|
||
| // Mimic old behavior with mb_substr | ||
| if ($i >= $this->text_length_chars) |
There was a problem hiding this comment.
Wrong coding style. It should be if ($i >= $this->text_length_chars) {.
peter279k
reviewed
Nov 27, 2020
src/HJSON/HJSONParser.php
Outdated
| $index = $this->at + $offs; | ||
|
|
||
| // Mimic old behavior with mb_substr | ||
| if ($index < 0) $index = 0; |
There was a problem hiding this comment.
Wrong coding style. It should be:
if ($index < 0) {
$index = 0;
}
trobro
approved these changes
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the faster parsing feature.
This is a branch off of test/large-json-parse-slow so those tests are included
See #24