Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: json: cannot unmarshal number #28

Merged
merged 2 commits into from
Jun 26, 2018
Merged

fix: json: cannot unmarshal number #28

merged 2 commits into from
Jun 26, 2018

Conversation

XooR
Copy link
Contributor

@XooR XooR commented Jun 26, 2018 •
edited
Loading

I have made serializer/deserializer for request duration because of bug in php-fpm it sometimes is number that is larger then int64 can handle.
I don't think that setting this value to zero will have negative impact because it is anyway gauge value.

@estahn
Copy link
Contributor

estahn commented Jun 26, 2018

@XooR Did you run the tests with go test -v ./...? I'm getting:

--- FAIL: TestCannotUnmarshalNumberIssue10 (0.00s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x690bd7]

@estahn estahn added the bug Something isn't working label Jun 26, 2018
@estahn estahn changed the title fixes hipages/php-fpm_exporter#26 fix: json: cannot unmarshal number Jun 26, 2018
@estahn estahn merged commit 03d8708 into hipages:master Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estahn estahn estahn approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@XooR @estahn