Update base.svelte #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I reference on https://frappe.io/charts/docs, because with the initial code, I have been getting this error: Error: 'Chart' is not exported by node_modules\frappe-charts\dist\frappe-charts.min.cjs.js, imported by node_modules\svelte-frappe-charts\src\components\base.svelte
himynameisdave
requested changes
Mar 20, 2021
There was a problem hiding this comment.
This is a known issue with frappe-charts, one that the primary maintainer is trying to fix in v2 of that library.
The easiest way to get around this issue is to configure your bundler to handle mixed CJS/ESM modules. In rollup this can be achieved with the @rollup/plugin-commonjs, specifically by enabling the transformMixedEsModules feature.
Closing this PR for now, but I appreciate you opening it! 👍
| import { Chart } from 'frappe-charts/dist/frappe-charts.min.cjs.js'; | ||
| import { Chart } from 'frappe-charts/dist/frappe-charts.esm.js' | ||
| // import css | ||
| import 'frappe-charts/dist/frappe-charts.min.css' |
There was a problem hiding this comment.
This is unneeded and is not included in the frappe-charts docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reference on https://frappe.io/charts/docs, because with the initial code, I have been getting this error:
Error: 'Chart' is not exported by node_modules\frappe-charts\dist\frappe-charts.min.cjs.js, imported by node_modules\svelte-frappe-charts\src\components\base.svelte