Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#49] Fix bug producing false positives in filters #50

Merged
merged 5 commits into from
Jul 13, 2023

Conversation

hiltontj
Copy link
Owner

This should close #49 - in which false positive query results were being produced by filters using relative singular query strings as comparables.

In addition to fixing the bug, some additional tracing instrumentation was added to lower level query evaluation functions.

@hiltontj hiltontj added the bug Something isn't working label Jul 13, 2023
@hiltontj hiltontj self-assigned this Jul 13, 2023
Copy link

@silverjam silverjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@hiltontj hiltontj merged commit 9b6e334 into main Jul 13, 2023
4 checks passed
@hiltontj hiltontj deleted the hiltontj/49-false--positives-from-filters branch July 13, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query satisfied with value from unrelated key
2 participants