FreeBSD rc script #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks ok. I'm not a user of FreeBSD myself, so I have to trust you on the quality of this. Gauging with my experience with systemd and Linux, this seems to be ok. Actually, I'm a friend of sane defaults. I don't see more knobs which should be offered by default. But if you want to provide a more advanced rc script I'm open for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’m using the exporter on a FreeBSD box via the existing pkg/port but I noticed there is no rc script included. So I wrote this super basic one that’s been working well for me.
I might have some time at some point to make it more configurable, but wanted to share the current version in case it’s helpful for someone else. And it can also easily be integrated in the pkg/port.
Let me know if you’d rather have the more advanced version and I’ll see if I can make some time to update it.