Scaling option for values #106

anegrin · 2022-11-28T17:47:26Z

optional mqtt_value_scale defines a scale for conversion; example use case: convert percentage into 0.0-1.0 value range

hikhvar

Hey,

I like that idea! I think we need some adjustments like using float64 to support scaling factors <1. And some more tests.

pkg/config/config.go

pkg/metrics/parser_test.go

pkg/metrics/parser.go

hikhvar · 2022-11-29T18:13:05Z

Thank you for your contribution and the patience.

anegrin added 2 commits November 28, 2022 18:39

scaling option for MQTT values

740352b

updated readme

a889c77

hikhvar requested changes Nov 28, 2022

View reviewed changes

pkg/config/config.go Outdated Show resolved Hide resolved

pkg/metrics/parser_test.go Show resolved Hide resolved

scale as unsigned float; tests for values from string or boolean

d077874

anegrin requested a review from hikhvar November 29, 2022 09:34

hikhvar reviewed Nov 29, 2022

View reviewed changes

pkg/metrics/parser.go Outdated Show resolved Hide resolved

scale as a multiplier

e766418

anegrin requested a review from hikhvar November 29, 2022 15:23

hikhvar approved these changes Nov 29, 2022

View reviewed changes

hikhvar merged commit 070e15f into hikhvar:master Nov 29, 2022

anegrin deleted the float-value-scale branch November 30, 2022 09:01

Provide feedback