Skip to content

Commit

Permalink
feat: Increase pod workers and workflow workers both to 32 by default. (
Browse files Browse the repository at this point in the history
  • Loading branch information
alexec committed Apr 16, 2020
1 parent 3a1990e commit e9589d2
Show file tree
Hide file tree
Showing 3 changed files with 50 additions and 3 deletions.
4 changes: 2 additions & 2 deletions cmd/workflow-controller/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,8 @@ func NewRootCommand() *cobra.Command {
command.Flags().StringVar(&containerRuntimeExecutor, "container-runtime-executor", "", "Container runtime executor to use (overrides value in configmap)")
command.Flags().StringVar(&logLevel, "loglevel", "info", "Set the logging level. One of: debug|info|warn|error")
command.Flags().IntVar(&glogLevel, "gloglevel", 0, "Set the glog logging level")
command.Flags().IntVar(&workflowWorkers, "workflow-workers", 8, "Number of workflow workers")
command.Flags().IntVar(&podWorkers, "pod-workers", 8, "Number of pod workers")
command.Flags().IntVar(&workflowWorkers, "workflow-workers", 32, "Number of workflow workers")
command.Flags().IntVar(&podWorkers, "pod-workers", 32, "Number of pod workers")
command.Flags().BoolVar(&namespaced, "namespaced", false, "run workflow-controller as namespaced mode")
command.Flags().StringVar(&managedNamespace, "managed-namespace", "", "namespace that workflow-controller watches, default to the installation namespace")
return &command
Expand Down
2 changes: 1 addition & 1 deletion hack/maybe-skip-job.sh
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ diffs=$(git diff --name-only origin/master)
rx=
case $job in
codegen)
rx='api/\|hack/\|manifests/\|pkg/'
rx='api/\|hack/\|examples/\|manifests/\|pkg/'
;;
docker-build)
# we only run on master as this rarely ever fails
Expand Down
47 changes: 47 additions & 0 deletions test/e2e/ui/ui-massive-workflow.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
# massive workflows
# 500 DAGs with 9 tasks a piece
apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
name: massive-workflow
spec:
entrypoint: main
templates:
- name: main
steps:
- - name: dag
template: dag
withSequence:
count: "500"
- name: dag
dag:
tasks:
- name: A
template: whalesay
- name: B
template: whalesay
dependencies: [A]
- name: C
template: whalesay
dependencies: [A]
- name: D
template: whalesay
dependencies: [B, C]
- name: E
template: whalesay
dependencies: [B, C]
- name: F
template: whalesay
dependencies: [B, C]
- name: G
template: whalesay
dependencies: [D, E, F]
- name: H
template: whalesay
dependencies: [D, E, F]
- name: I
template: whalesay
dependencies: [D, E, F]
- name: whalesay
container:
image: docker/whalesay:latest

0 comments on commit e9589d2

Please sign in to comment.