Skip to content

Commit

Permalink
docs: Fix wrong Configuring Your Artifact Repository document. (argop…
Browse files Browse the repository at this point in the history
  • Loading branch information
Eji4h committed Apr 3, 2020
1 parent 79217bc commit c3535ba
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions docs/configure-artifact-repository.md
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ artifacts:
key: serviceAccountKey
```

If it's a GEK cluster, and Workload Identity is configured, there's no need to
If it's a GKE cluster, and Workload Identity is configured, there's no need to
create the Service Account key and store it as a K8s secret,
`serviceAccountKeySecret` is also not needed in this case. Please follow the
link to configure Workload Identity
Expand Down Expand Up @@ -200,18 +200,18 @@ $ kubectl edit configmap workflow-controller-configmap -n argo # assumes argo w
...
data:
config: |
artifactRepository: |
artifactRepository:
s3:
bucket: my-bucket
keyPrefix: prefix/in/bucket #optional
endpoint: my-minio-endpoint.default:9000 #AWS => s3.amazonaws.com; GCS => storage.googleapis.com
insecure: true #omit for S3/GCS. Needed when minio runs without TLS
accessKeySecret: #omit if accessing via AWS IAM
name: my-minio-cred
key: accesskey
key: accessKey
secretKeySecret: #omit if accessing via AWS IAM
name: my-minio-cred
key: secretkey
key: secretKey
useSDKCreds: true #tells argo to use AWS SDK's default provider chain, enable for things like IRSA support
```

Expand Down

0 comments on commit c3535ba

Please sign in to comment.