Allow roles to run with INJECT_FACTS_AS_VARS set to false

[kennethso168]

Currently, the role failed to run with INJECT_FACTS_AS_VARS set to false as the required ansible_* variables (I believe they are ansible_distribution and ansible_distribution_release in this role) are not defined.

The configuration INJECT_FACTS_AS_VARS and the Ansible fact namespace ansible_facts.* has been added in Ansible 2.5. In the porting guide of that version it stated that:

A new configuration variable, inject_facts_as_vars, has been added to ansible.cfg. Its default setting, ‘True’, keeps the 2.4 behavior of facts variables being set in the old ansible_* locations (while also writing them to the new namespace). This variable is expected to be set to ‘False’ in a future release. When inject_facts_as_vars is set to False, you must refer to ansible_facts through the new ansible_facts.* namespace.

It was also confirmed by Ansible developer on reddit that INJECT_FACTS_AS_VARS was planned to be deprecated in the future.

Therefore, it would be great if the role supported INJECT_FACTS_AS_VARS=false as well.

To fix this just change all ansible_* variables to ansible_facts.*. This should work with ansible versions >= 2.5. I can do a PR when I have time.

[Normo]

Thanks @kennethso168 for reporting this. So if you want, please create a PR.
Thanks a lot in advance!

[kennethso168]

Thanks, will create a PR when I have time

…

On Wed, Feb 21, 2024, 19:59 Norman Ziegner ***@***.***> wrote: Thanks @kennethso168 <https://github.com/kennethso168> for reporting this. So if you want, please create a PR. Thanks a lot in advance! — Reply to this email directly, view it on GitHub <#185 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABIEZF6IQ42BSUVNE6KZHHDYUXORJAVCNFSM6AAAAABDSYUN3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJWGQ4TOMBQGY> . You are receiving this because you were mentioned.Message ID: ***@***.*** com>