-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow roles to run with INJECT_FACTS_AS_VARS set to false #185
Milestone
Comments
Thanks @kennethso168 for reporting this. So if you want, please create a PR. |
Thanks, will create a PR when I have time
…On Wed, Feb 21, 2024, 19:59 Norman Ziegner ***@***.***> wrote:
Thanks @kennethso168 <https://github.com/kennethso168> for reporting
this. So if you want, please create a PR.
Thanks a lot in advance!
—
Reply to this email directly, view it on GitHub
<#185 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABIEZF6IQ42BSUVNE6KZHHDYUXORJAVCNFSM6AAAAABDSYUN3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJWGQ4TOMBQGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the role failed to run with
INJECT_FACTS_AS_VARS
set tofalse
as the requiredansible_*
variables (I believe they areansible_distribution
andansible_distribution_release
in this role) are not defined.The configuration
INJECT_FACTS_AS_VARS
and the Ansible fact namespaceansible_facts.*
has been added in Ansible 2.5. In the porting guide of that version it stated that:It was also confirmed by Ansible developer on reddit that
INJECT_FACTS_AS_VARS
was planned to be deprecated in the future.Therefore, it would be great if the role supported
INJECT_FACTS_AS_VARS=false
as well.To fix this just change all
ansible_*
variables toansible_facts.*
. This should work with ansible versions >= 2.5. I can do a PR when I have time.The text was updated successfully, but these errors were encountered: