Fix for xmltodict v0.13. Fixes #53 #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xmltodict v0.13 started using dict (instead of previous default OrderedDict) when parsing xml with python < 3.7. See martinblech/xmltodict@231b4d4 This restores the previous behaviour, using OrderedDict, making the behaviour compatible with dsptoolkit. The change should be backwards compatible with older versions of xmltodict, as dict_constructor parameter has been there for quite some time. Signed-off-by: Sami Salonen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xmltodict v0.13 started using dict (instead of previous default OrderedDict) when parsing xml with python >= 3.7. See martinblech/xmltodict@231b4d4
This restores the previous behaviour, using OrderedDict, making the behaviour compatible with dsptoolkit. The change should be backwards compatible with older versions of xmltodict, as dict_constructor parameter has been there for quite some time.