HHH-16233 Fix logs for mutable non-root entity #6169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
shin-mallang
changed the title
|
Oops, I suck! |
|
@gavinking Did I do a good job?? |
Yes, sure, we just need to make sure the tests pass. |
|
Oh, great! I'm glad I can contribute to Hibernate😊 |
|
Merged, thanks! |
|
I'm honored😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An incorrect error log message is given about @immutable is declared to non-root entities that are not @immutable declared.
@immutable can only be declared on the Root Entity.
That is, it is not wrong to say that a non-root entity is mutable, so should not send the message
@Immutable used on a non root entityto non-root entity that are not declared with @immutable.This should only happen for non-root entities that are immutable.
https://hibernate.atlassian.net/jira/software/c/projects/HHH/issues/HHH-16233