This repository has been archived by the owner on Apr 1, 2024. It is now read-only.
Refactor take 2 #139
Closed
Refactor take 2 #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- all tests pass, including tests added that failed against previous PR - every element renders itself and it's children - all child rendering is async - so, the XHP tree becomes a corresponding async tree This means that asyncRender() at different depths in the tree can be executing simultaneously. There shouldn't be much of a performance cost, as HHVM should convert things things to a StaticWaitHandle when XHPAsync isn't being used. fixes hhvm#136 fixes hhvm#85
|
|
||
| $this->assertGreaterThan($max_start, $min_mid, 'all should be started before any get continued'); | ||
| $this->assertGreaterThan($max_mid, $min_finish, 'all should have reached stage two before any finish'); | ||
| $this->assertGreaterThan($max_start, $min_finish, 'sanity check: all have started before any finish'); |
There was a problem hiding this comment.
This is actually the only one that matches HHVM's guarantees - the others match as long as HHVM keeps on eagerly executing until it sees a native waithandle, which is likely (though not certain) to continue.
|
ping |
| } | ||
| } | ||
| if ($awaitables) { | ||
| $awaited = await HH\Asio\m($awaitables); |
|
Well everything looks good to me. Excited to get this in and see if things of mine break from validation that was never being run before. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that asyncRender() at different depths in the tree can be executing simultaneously.
There shouldn't be much of a performance cost, as HHVM should convert things things
to a StaticWaitHandle when XHPAsync isn't being used.
fixes #136
fixes #85