[core] fix cache introduced by getHashByNumber (harmony-one#3814)

hhio618 · Jul 7, 2021 · 7b0f6ac · 7b0f6ac
1 parent ab5be8f
commit 7b0f6ac
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/core/headerchain.go b/core/headerchain.go
@@ -454,7 +454,9 @@ func (hc *HeaderChain) getHashByNumber(number uint64) common.Hash {
  return hash.(common.Hash)
  }
  hash := rawdb.ReadCanonicalHash(hc.chainDb, number)
- hc.canonicalCache.Add(number, hash)
+ if hash != (common.Hash{}) {
+ hc.canonicalCache.Add(number, hash)
+ }
  return hash
 }