fix: unknown MIFARE tag error. #5
Conversation
…passed in is not what C code expects
|
Hi @choongyong Thank you for your PR! |
|
Hi, @hexdigest, I checked out libfreefare from this repository: |
|
Here is what I found in libfreefare-dev Ubuntu's package (freefare.h): struct mifare_tag;
typedef struct mifare_tag *MifareTag;
MifareTag freefare_tag_new (nfc_device *device, nfc_iso14443a_info nai);Here is what I found in the repository I pointed out in the documentation: https://github.com/nfc-tools/libfreefare/blob/master/libfreefare/freefare.h: struct freefare_tag;
typedef struct freefare_tag *FreefareTag;
FreefareTag freefare_tag_new(nfc_device *device, nfc_target target);I believe at the point I was writing the documentation everything worked but at since then repositories diverged. Current ruby-nfc implementation works for Ubuntu users but doesn't work for those who install libfreefare from the git repository. I think ubuntu's version of libfreefare is outdated so let me check other functions signatures before I merge this PR. |
|
@hexdigest Thanks for checking :) |
|
@choongyong thank you! I also removed reference to Ubuntu's version of libfreefare from the install doc and I'm going to update the gem today. |
When I run the example script, after fixing it with the change in #4, I get the following error:
After tracing the code, I found that in libfreefare/libfreefare/freefare.c, the method
freefare_tag_newis defined as:However in `ruby-nfc/lib/tags/mifare/tag.rb, the following is defined:
And the method call is:
The pointer type defined and pointer type passed in is not what C the code expects. I applied the changes in this PR, and the reader is able to read the cards properly now.