Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo "Biologic Class" in metagraph #36

Closed
dhimmel opened this issue Jun 22, 2020 · 3 comments · Fixed by #37
Closed

Typo "Biologic Class" in metagraph #36

dhimmel opened this issue Jun 22, 2020 · 3 comments · Fixed by #37

Comments

@dhimmel
Copy link
Member

dhimmel commented Jun 22, 2020

typo in about/metagraph.png:

Should be "Biological Process" not "Biologic Class". There are several other versions of this image at https://github.com/hetio/het.io/tree/gh-pages/about.

@vincerubinetti do we still have the source for this image and would this be fixable?

@dhimmel
Copy link
Member Author

dhimmel commented Jun 23, 2020

Those look good. Do you want to go ahead and commit them to this repo?

Also remind me what the source is... i.e. how this was generated and whether we have that source file tracked anywhere?

@vincerubinetti
Copy link
Collaborator

vincerubinetti commented Jun 23, 2020

I'll commit this change when I fix the other issues with the site. Have been having problems today trying to get ruby and jekyll to build the site locally on my Windows machine, but I'll still have it ready for you to review tomorrow.

The source is in my google drive. It's a "diagrams.net" (originally "draw.io"?) document:
image

Here is the document in my google drive:
https://drive.google.com/file/d/1E1Cku_gYtHHIe-lvenULVUo-gNucqNWZ/view?usp=sharing

I'll include the draw.io (which I just now figured out how to save), svg, and png versions in the commit to the website.

@vincerubinetti
Copy link
Collaborator

metagraph.zip

vincerubinetti added a commit that referenced this issue Jun 24, 2020
closes #32 
closes #36 

- splits cite into two individually linkable sections
- adds PMID and PMCID to citations
- fixes "biologic class" to "biological process"
- renames some rephetio titles to be consistent
- adds some other small text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants