Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "relationships" to "edges" #33

Closed
dhimmel opened this issue Aug 23, 2019 · 5 comments
Closed

Change "relationships" to "edges" #33

dhimmel opened this issue Aug 23, 2019 · 5 comments

Comments

@dhimmel
Copy link
Member

dhimmel commented Aug 23, 2019

I'll comment below with any tooltip tweaks we should make

dhimmel added a commit to hetio/disease-genes-frontend that referenced this issue Aug 23, 2019
@dhimmel
Copy link
Member Author

dhimmel commented Aug 23, 2019

At https://hetio.github.io/repurpose-frontend/?tab=diseases&id=DOID_2841

image

Highlighted term should be "edges" not "relationships" for consistency with other tables.

Also effects https://hetio.github.io/repurpose-frontend/?tab=compounds&id=DB01048

@dhimmel
Copy link
Member Author

dhimmel commented Aug 23, 2019

https://hetio.github.io/repurpose-frontend/?tab=metapaths only has 121 rows, but should have many more (1206). My guess is that all rows with a missing coefficient have been filtered out?

@vincerubinetti
Copy link
Collaborator

https://hetio.github.io/repurpose-frontend/?tab=metapaths only has 121 rows, but should have many more (1206). My guess is that all rows with a missing coefficient have been filtered out?

121 is the number of pages, not number rows. So that means there are at least 1210 rows. The number of rows is shown in the upper left corner:

image

@dhimmel
Copy link
Member Author

dhimmel commented Aug 26, 2019

The number of rows is shown in the upper left corner:

Ah got it. The metapaths table has the right number of entries, but it looks like the null coefficients are getting set to 0.000. They should remain blank because they are distinct from the actual zeros.

vincerubinetti pushed a commit to hetio/disease-genes-frontend that referenced this issue Aug 28, 2019
#13

- update tooltip text 
- related: hetio/het.io#33
@vincerubinetti vincerubinetti changed the title Tooltip tweaks Change "relationships" to "edges" Aug 28, 2019
@vincerubinetti
Copy link
Collaborator

Closed by hetio/repurpose-frontend#20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants