Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[changelog skip] Fix PR edit check #409

Merged
merged 1 commit into from
May 12, 2020
Merged

[changelog skip] Fix PR edit check #409

merged 1 commit into from
May 12, 2020

Conversation

schneems
Copy link
Contributor

Previously when a PR title was edited, the "check for changelog" script would not fire. This means if someone edited it to add a "[changelog skip]" that the check would still show to be failing. This PR adds additional triggers for the check so that when the PR is edited, the check will re-run.


Previously when a PR title was edited, the "check for changelog" script would not fire. This means if someone edited it to add a "[changelog skip]" that the check would still show to be failing. This PR adds additional triggers for the check so that when the PR is edited, the check will re-run.
@schneems schneems requested a review from a team as a code owner May 11, 2020 16:14
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this; it was driving me up the wall the other day! :-)

@schneems schneems merged commit e89e8b5 into master May 12, 2020
@schneems schneems deleted the schneems-patch-1 branch May 12, 2020 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants