Massage the pkg spec found in Godep.json for vendor #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Godep can save other packages other than what's local. This is usually used to vendor one or more additional main packages like github.com/mattes/migrate. With the old school godep workspace this just worked because the workspace was added to the GOPATH by `godep go install`. But with the vendor experiment we need to prefix those paths with the `<the package>/vendor` for them to be `go install`able. So this patch checks to see if the directory for the packages that aren't `.*` packages exists in `<repo>/vendor` and if they do, alters the package name to `<repo package name>/vendor/<package>`.
|
This has solved the issue for us, which @bernerdschaefer was helping me out with. |
|
👍 |
freeformz
pushed a commit
that referenced
this pull request
Apr 25, 2016
Includes: - massage the installable package spec to include the name + vendor directory when vendor is used: #120
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Godep can save other packages other than what's local.
This is usually used to vendor one or more additional main packages like
github.com/mattes/migrate. With the old school godep workspace this just
worked because the workspace was added to the GOPATH by
godep go install. But with the vendor experiment we need to prefix those pathswith the
<the package>/vendorfor them to bego installable.So this patch checks to see if the directory for the packages that
aren't
.*packages exists in<repo>/vendorand if they do, altersthe package name to
<repo package name>/vendor/<package>.