Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct locale loading #355

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Correct locale loading #355

merged 3 commits into from
Feb 28, 2024

Conversation

johlym
Copy link

@johlym johlym commented Feb 28, 2024

After upgrading to Ruby 3.3, this path stopped getting populated correctly, and as such, we no longer had any defined localizations. It wasn't reproducible locally, so was missed in recent updates.

Also dropped bundle exec from the Procfile – running the app in that context is causing an error somewhere in the chain that is being swallowed; bundle is exiting 0 and not being helpful. There really isn't a great reason to bundle exec a Sinatra app that I can think of... generally one uses ruby directly or through Rack with rackup.

@johlym johlym self-assigned this Feb 28, 2024
@johlym johlym requested a review from a team as a code owner February 28, 2024 20:19
@heroku heroku bot temporarily deployed to twelve-factor-staging February 28, 2024 20:20 Inactive
@heroku heroku bot temporarily deployed to twelve-factor-staging February 28, 2024 20:24 Inactive
@heroku heroku bot temporarily deployed to twelve-factor-staging February 28, 2024 20:28 Inactive
@johlym johlym merged commit 736a986 into main Feb 28, 2024
3 checks passed
@johlym johlym deleted the johlym/fix-locale-loading branch February 28, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants