Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some typos in the french translation #166

Merged
merged 13 commits into from
Nov 10, 2017
Merged

Fix some typos in the french translation #166

merged 13 commits into from
Nov 10, 2017

Conversation

IvanOdd
Copy link

@IvanOdd IvanOdd commented Nov 1, 2017

No description provided.

Copy link

@dmathieu dmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci Simon!
J'ai laissé un seul commentaire, pour lequel je pourrai peut-être me tromper.

I've left a single comment for which I may be wrong.

@@ -1,22 +1,22 @@
## III. Configuration
### Stockez la configuration dans l'environnement

La *configuration* d'une application est tout ce qui est susceptible de varier entre des [déploiements](./codebase) (validation, production, environnement de développement, etc). Cela inclut :
La *configuration* d'une application est tout ce qui est susceptible de varier entre des [déploiements](./codebase) (validation, production, environnement de développement, etc.). Cela inclut :

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure we need the dot here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya it's not strictly required. Usually abbreviations are ended with a dot, some correctors consider this as a mistake if there is none.
But sure, we can skip it if you prefer, it's absolutely not mandatory. Just an expression of my nevrotic mind :)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, due to it being an abbreviation, of course.
I thought you were adding it as the end of a phrase, which seemed weird for a parenthesis.

@raul
Copy link

raul commented Nov 10, 2017

Thank you both! Looks like there's a conflict caused by 58e0bb9, which added systemd - would you mind taking a look at it @smalesys ?

@raul
Copy link

raul commented Nov 10, 2017

The specific change in the French content is here.

@IvanOdd
Copy link
Author

IvanOdd commented Nov 10, 2017

Done :)

@raul
Copy link

raul commented Nov 10, 2017

Wonderful, thanks a lot! :)

@raul raul merged commit 1ec258b into heroku:master Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants